Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ItemMetadata to NKFile conversion as NKFile extension method #26

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

claucambra
Copy link
Owner

Simplifies this a lot

Simplifies this a lot

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra self-assigned this Dec 2, 2024
@claucambra claucambra changed the title Refactor ItemMetadata to NKDile conversion as NKFile extension method Refactor ItemMetadata to NKFile conversion as NKFile extension method Dec 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.10526% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.55%. Comparing base (6bc6961) to head (61e7b3d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...FileProviderKit/Extensions/NKFile+Extensions.swift 93.05% 5 Missing ⚠️
...roviderKit/Enumeration/Enumerator+SyncEngine.swift 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   76.55%   76.55%           
=======================================
  Files          38       39    +1     
  Lines        8174     8174           
=======================================
  Hits         6258     6258           
  Misses       1916     1916           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…using

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra merged commit c29e493 into main Dec 3, 2024
3 checks passed
@claucambra claucambra added this to the 2.0.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants