Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NextcloudKit 5.X #27

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Upgrade to NextcloudKit 5.X #27

merged 9 commits into from
Dec 11, 2024

Conversation

claucambra
Copy link
Owner

No description provided.

@claucambra claucambra self-assigned this Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.47170% with 78 lines in your changes missing coverage. Please review.

Project coverage is 76.92%. Comparing base (88d9ab9) to head (0a44717).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...erKit/Interface/NextcloudKit+RemoteInterface.swift 0.00% 31 Missing ⚠️
Tests/Interface/MockRemoteInterface.swift 72.50% 11 Missing ⚠️
...tcloudFileProviderKit/Enumeration/Enumerator.swift 71.87% 9 Missing ⚠️
...ProviderKit/Enumeration/RemoteChangeObserver.swift 40.00% 9 Missing ⚠️
...roviderKit/Enumeration/Enumerator+SyncEngine.swift 76.19% 5 Missing ⚠️
...es/NextcloudFileProviderKit/Item/Item+Modify.swift 80.00% 5 Missing ⚠️
...es/NextcloudFileProviderKit/Item/Item+Create.swift 88.46% 3 Missing ⚠️
...dFileProviderKit/Utilities/ThumbnailFetching.swift 0.00% 3 Missing ⚠️
...ces/NextcloudFileProviderKit/Item/Item+Fetch.swift 87.50% 1 Missing ⚠️
Sources/NextcloudFileProviderKit/Item/Item.swift 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   76.73%   76.92%   +0.19%     
==========================================
  Files          37       37              
  Lines        8114     8244     +130     
==========================================
+ Hits         6226     6342     +116     
- Misses       1888     1902      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

f delegate

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…s parameter

In NextcloudKit, the main NextcloudKit object now supports multiple
sessions and the methods of this object takes in the account identifier
string (for us, ncKitAccount in Account) to allow for multi-user use.
Additionally the constructor for NextcloudKit is now internal so we
cannot use multiple instances of NextcloudKit

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra merged commit f5ba719 into main Dec 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants