Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Update to Bootstrap v4.3.1 #21

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Update to Bootstrap v4.3.1 #21

wants to merge 33 commits into from

Conversation

dennisholmer
Copy link

Solves issue #7

@dennisholmer dennisholmer mentioned this pull request Jun 10, 2019
Open
@dennisholmer
Copy link
Author

dennisholmer commented Jun 10, 2019 •
edited
Loading

This contains breaking changes to all projects that still have BS 3.

davidst
davidst suggested changes Jun 19, 2019
View reviewed changes
Copy link
Collaborator

@davidst davidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you changed the formatting from 4 spaces to 2 spaces. This makes the diff very hard to follow and is also inconsistent with the rest of the files in the project. Can you please go back to 4 spaces formatting?

@dennisholmer
Copy link
Author

dennisholmer commented Jun 19, 2019 •
edited
Loading

Uhm, was this better? It was inconsistent before I made changes. Should TS have 2 and HTML/CSS have 4 or should all have 4? As you can see I updated the .editorconfig and tslint.json to 4 spaces.

@andrewryan1906
Copy link

Hey, any movement on this? I'm assuming until this is done, this component won't work with Bootstrap 4?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidst davidst davidst requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dennisholmer @andrewryan1906 @davidst @viktor-mezhenskyi