Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify md output encoding as utf-8 #90

Merged
merged 2 commits into from
Apr 30, 2024
Merged

specify md output encoding as utf-8 #90

merged 2 commits into from
Apr 30, 2024

Conversation

L4ys
Copy link
Contributor

@L4ys L4ys commented Apr 10, 2024

Specify md output encoding as utf-8 to prevent some encoding errors on non-English language systems

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\test\scoop\apps\python311\current\Scripts\ghidriff.exe\__main__.py", line 7, in <module>
  File "C:\Users\test\scoop\apps\python311\current\Lib\site-packages\ghidriff\__main__.py", line 94, in main
    d.dump_pdiff_to_path(diff_name,
  File "C:\Users\test\scoop\apps\python311\current\Lib\site-packages\ghidriff\ghidra_diff_engine.py", line 1716, in dump_pdiff_to_path
    f.write(diff_text)
UnicodeEncodeError: 'cp950' codec can't encode character '\xa9' in position 8649: illegal multibyte sequence

@clearbluejar
Copy link
Owner

good catch! I want to see if any other of the writes need the update as well. will check back in here soon.

@clearbluejar
Copy link
Owner

added encoding to two other writes. should be good.

@clearbluejar clearbluejar merged commit 7405636 into clearbluejar:main Apr 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants