Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previously broken test #1022

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented Jan 17, 2024

Instead of triggering the code path at

default:
throw new Error(`Invalid version of scancode: ${scancodeVersion}`)
, this test previously just tested its own throw new Error line. This is now fixed and the expected error message and fixture adjusted to make the test actually work.

Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this move toward consistency in case. And great fix on the test.

@lumaxis lumaxis merged commit 04e1794 into clearlydefined:master Jan 29, 2024
2 checks passed
@lumaxis lumaxis deleted the fix-broken-test branch January 29, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants