Use dependency injection in PypiCoordinatesMapper #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix the CodeQL scanning failure and make stubbing network call easier in unit tests.
lumaxis
approved these changes
Mar 13, 2024
| @@ -21,19 +22,16 @@ class PypiCoordinatesMapper { | |||
| } | |||
|
|
|||
| async _resolve(coordinates) { | |||
| if (coordinates.name === '..') return null | |||
There was a problem hiding this comment.
I was wondering if we want a more generalized function to sanitize coordinates? But also fine as is 👍🏼
There was a problem hiding this comment.
I thought about this as well: using URL object and the check /../ in the final url can be refactored into a function. I will do the refactoring as a separate PR. The check for / in coordinates.name is specific to coordinates, which maybe harder to refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the CodeQL scanning failure and make stubbing network call easier in unit tests.