Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shared dev deploy workflow in operations #1092

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Conversation

elrayle
Copy link
Collaborator

@elrayle elrayle commented Apr 11, 2024

Description

The dev deploy workflow that was in service was moved to clearlydefined/operations and generalized for use in all 3 major apps (i.e. service, crawler, and website).

The service is the first test candidate. With the successful deploy of the service, the shared script will be used to deploy the apps.

Prerequisite

The following PR must be merged ahead of this PR. It adds the shared deploy script in clearlydefined/operations.

@elrayle elrayle marked this pull request as draft April 11, 2024 20:07
@elrayle elrayle marked this pull request as ready for review April 11, 2024 20:42
@elrayle elrayle marked this pull request as draft April 11, 2024 21:07
Copy link

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So clean. Nice work.

Copy link
Collaborator

@qtomlinson qtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you.

bin/config.js Outdated Show resolved Hide resolved
@elrayle elrayle force-pushed the elr/shared-dev-deploy branch 2 times, most recently from 88e3774 to 562a5d4 Compare April 27, 2024 00:03
elrayle added 2 commits April 26, 2024 20:05
* use consistent naming for build-and-deploy workflows
* make workflow display name easier to scan
@elrayle elrayle force-pushed the elr/shared-dev-deploy branch from 562a5d4 to c716317 Compare April 27, 2024 00:07
@elrayle elrayle force-pushed the elr/shared-dev-deploy branch from a92003c to 13bdb15 Compare April 27, 2024 00:52
@elrayle elrayle force-pushed the elr/shared-dev-deploy branch from 9b1a5cc to f04cf71 Compare April 29, 2024 14:15
@elrayle elrayle marked this pull request as ready for review April 29, 2024 14:25
@elrayle elrayle merged commit 647caa9 into master Apr 29, 2024
12 checks passed
@elrayle elrayle deleted the elr/shared-dev-deploy branch April 29, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants