-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use shared dev deploy workflow in operations #1092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeridth
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. So clean. Nice work.
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
from
April 15, 2024 14:44
cca9438
to
d470e4f
Compare
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
2 times, most recently
from
April 15, 2024 21:18
511305f
to
b805c7f
Compare
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
from
April 16, 2024 17:11
1d592c9
to
669f9fa
Compare
qtomlinson
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thank you.
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
2 times, most recently
from
April 27, 2024 00:03
88e3774
to
562a5d4
Compare
* use consistent naming for build-and-deploy workflows * make workflow display name easier to scan
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
from
April 27, 2024 00:07
562a5d4
to
c716317
Compare
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
from
April 27, 2024 00:52
a92003c
to
13bdb15
Compare
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
from
April 29, 2024 14:15
9b1a5cc
to
f04cf71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dev deploy workflow that was in service was moved to clearlydefined/operations and generalized for use in all 3 major apps (i.e. service, crawler, and website).
The service is the first test candidate. With the successful deploy of the service, the shared script will be used to deploy the apps.
Prerequisite
The following PR must be merged ahead of this PR. It adds the shared deploy script in clearlydefined/operations.