-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated deprecated dependency request-promise-native #1163
Updated deprecated dependency request-promise-native #1163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qtomlinson I request your help to test all the requestPromise calls in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested against dev instance. Also adding integration test for this. See clearlydefined/operations#89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qtomlinson I request your help to test all the requestPromise calls in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested against dev instance. Also adding integration test for this. See clearlydefined/operations#89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qtomlinson I request your help to test the requestPromise call(_fetch) in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with pypi/pypi/-/backports.ssl-match_hostname/3.7.0.1
Add relevant tests. Remove the integration tests to download crate components
d9b7a1d
to
cec14d2
Compare
Pull update request promise
cec14d2
to
f99cf6b
Compare
f99cf6b
to
b2895db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for taking care of this technical debt.
The service code has been updated to replace the deprecated dependency, request-promise-native, with axios. The following tasks have been performed:
Future scope -
This PR is related to the issue #1090