add APP_VERSION & BUILD_SHA to Dockerfiles #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add closing curly brace to status message
This was referenced Sep 30, 2024
More explicit as that is what we are releasing
This is set by Azure devops image build Image is not built by azdo anymore so not needed
RomanIakovlev
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets up the docker image to hold the version and sha that are used to verify which version is actually running. The previous approach used Azure configs that get set just before the deploy. If the deploy were to fail, those configs stay the same leading to a false report on the version and sha.
This change requires the change in the operations shared workflows before it will start drawing from the environment variables set in the docker image. It is OK to merge this as the same named Azure configs will still be available.
Related Work