Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment pipelines 3 1 1 #1209

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Conversation

ljones140
Copy link
Contributor

Updates deployment pipeline.

Important that prod is updated as we will now send App Version and Build Sha to docker image when built.
This will be returned on GET https://api.clearlydefined.io/

Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise looks good. Thanks for adding the artifact!

.github/workflows/build-and-deploy-prod.yml Show resolved Hide resolved
ljones140 and others added 2 commits October 24, 2024 15:50
Co-authored-by: E. Lynette Rayle <elrayle@users.noreply.github.com>
Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for bringing this workflow in line with the others.

@elrayle elrayle merged commit 93eca1c into master Oct 24, 2024
4 checks passed
@elrayle elrayle deleted the update-deployment-pipelines-3-1-1 branch October 24, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants