Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fenders #27

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fenders #27

merged 1 commit into from
Jul 31, 2023

Conversation

luis-camero
Copy link
Collaborator

And by default all attachments are disabled, i.e. if their entries are left empty.

tonybaltovski
tonybaltovski reviewed Jul 31, 2023
View reviewed changes
clearpath_config/platform/types/mux.py
@@ -39,7 +39,7 @@ class AttachmentMux():
MODEL = {
BUMPER: Bumper,
TOP_PLATE: TopPlate,
STRUCTURE: Structure
STRUCTURE: Structure,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra comma?

tonybaltovski
tonybaltovski approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@tonybaltovski tonybaltovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit.

@luis-camero luis-camero merged commit 669a32f into main Jul 31, 2023
1 check passed
@luis-camero luis-camero deleted the fenders branch August 9, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonybaltovski tonybaltovski tonybaltovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luis-camero @tonybaltovski