Min replicas extra manifests #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemlesne
requested changes
Nov 17, 2023
|
Hello @wolviecb, thank you for your patience. You'll find comments attached to my review. |
Thanks for the comments :) |
Co-authored-by: Thomas Andrade <thomas.meira.de.andrade@volvocars.com>
clemlesne
approved these changes
Nov 22, 2023
|
Merge commit ref e4b686e. I updated a bit of the code, fixing lint and code quality. Behavior remains unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds the following features:
minReplicaCounton theScaleJobdefinition to an arbitrary value instead of having it hard coded.organizationURLonly mandatory if you set the chart to create the required secret