[Helm] Add .Values.revisionHistoryLimit #243
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemlesne
reviewed
Aug 31, 2024
| @@ -10,6 +10,7 @@ spec: | |||
| matchLabels: | |||
| {{- include "blue-agent.selectorLabels" . | nindent 6 }} | |||
| replicas: {{ .Values.replicaCount | int | required "A value for .Values.replicaCount is required" }} | |||
| revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} | |||
There was a problem hiding this comment.
Missing int cast, required constraint and and custom error message (like the above line).
clemlesne
reviewed
Aug 31, 2024
| @@ -126,6 +126,9 @@ tolerations: [] | |||
| # Pod affinity configuration | |||
| affinity: {} | |||
|
|
|||
| # Number of revisions to keep in the history of the Deployment | |||
There was a problem hiding this comment.
Value to 0 will cause the inability to rollback. Can you specify the documentation link as note plus a warning?
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ! Just a small PR to allow us to customize the revisionHistoryLimit of the agents Deployment, thanks for your work :)