fix: add customPreStopCommand value #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemlesne
reviewed
Aug 31, 2024
| @@ -166,6 +166,9 @@ containers: | |||
| rm -rf ${TMPDIR}; | |||
| {{- end }} | |||
| {{- end }} | |||
| {{- range .Values.pipelines.customPreStopCommand }} | |||
| - "{{ . }}" | |||
There was a problem hiding this comment.
If the above conditions are false and the new variable is kept as its default, the same bug will occur. This will force users to debug the install process for a dumb issue.
Plus, note that the issue should appear on Windows, which is not covered by this fix.
I propose adding final else statements for each block (Windows and Linux) with something like true instead of the command. This is simpler and will work out of the box.
|
Thank you @Riqardos for this PR, I really appreciate. I sent a comment, for a quick fix. |
Riqardos
force-pushed
the
fix-preStop-command
branch
from
cb715ad
to
2460261
Compare
|
@clemlesne I think the issue is solved in the this PR, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
customPreStopCommandto be able to customizepreStopbehavior