-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repo): playground workspace: protocol #4599
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
50d15c5
to
808a4f6
Compare
@jacekradko does this include all the playgrounds as workspaces? Not sure if we want to do that...we don't want to have to install all of these deps by default. |
@BRKalow Yes, it would. I am just testing this out and seeing what impact if would have on install times. pnpm should mitigate most of the additional cost of additional packages getting install, especially if we lean into I think there is a case to be made for these packages to be treated as part of the workspace as it makes DX within the monorepo much easier. No need for yalc-ing things around and automatically getting interlinked packages |
Description
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change