Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): playground workspace: protocol #4599

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacekradko
Copy link
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 808a4f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 4:08am

@BRKalow
Copy link
Member

BRKalow commented Nov 21, 2024

@jacekradko does this include all the playgrounds as workspaces? Not sure if we want to do that...we don't want to have to install all of these deps by default.

@jacekradko
Copy link
Member Author

@BRKalow Yes, it would. I am just testing this out and seeing what impact if would have on install times. pnpm should mitigate most of the additional cost of additional packages getting install, especially if we lean into catalog: protocol to use as few versions of the same package as possible.

I think there is a case to be made for these packages to be treated as part of the workspace as it makes DX within the monorepo much easier. No need for yalc-ing things around and automatically getting interlinked packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants