-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(astro): Introduce <Waitlist />
component
#4650
feat(astro): Introduce <Waitlist />
component
#4650
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: dcf50c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
34ae4db
to
2b84c8c
Compare
2b84c8c
to
9783b86
Compare
<Waitlist />
component
<Waitlist />
component <Waitlist />
component
<Waitlist />
component <Waitlist />
component
@nikospapcom don't we also need WaitList as a modal ? |
9783b86
to
dcf50c3
Compare
!snapshot |
Hey @nikospapcom - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@1.5.0-snapshot.v20241125153146 --save-exact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Re: WaitList as a modal @panteliselef - I don't think there's a separate WaitList modal component in @clerk/clerk-react
, but they can use $clerkStore.get().openWaitlist()
instead ❓
@wobsoriano we discussed offline with Pantelis and you're right, they can use |
Description
In this pr we're introducing
<Waitlist />
component for astroChecklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change