Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro): Introduce <Waitlist /> component #4650

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

nikospapcom
Copy link
Member

@nikospapcom nikospapcom commented Nov 25, 2024

Description

In this pr we're introducing <Waitlist /> component for astro

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@nikospapcom nikospapcom self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 3:32pm

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: dcf50c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikospapcom nikospapcom force-pushed the nikospap/user-1084-support-waitlist-for-astro branch from 34ae4db to 2b84c8c Compare November 25, 2024 10:29
@clerk clerk deleted a comment from clerk-cookie Nov 25, 2024
@nikospapcom nikospapcom force-pushed the nikospap/user-1084-support-waitlist-for-astro branch from 2b84c8c to 9783b86 Compare November 25, 2024 11:07
@nikospapcom nikospapcom changed the title [WIP] feat: Add Waitlist component in astro [WIP] feat(astro): Introduce <Waitlist /> component Nov 25, 2024
@clerk clerk deleted a comment from clerk-cookie Nov 25, 2024
@nikospapcom nikospapcom changed the title [WIP] feat(astro): Introduce <Waitlist /> component feat(astro): Introduce <Waitlist /> component Nov 25, 2024
@nikospapcom nikospapcom changed the title feat(astro): Introduce <Waitlist /> component feat(astro): Introduce <Waitlist /> component Nov 25, 2024
@nikospapcom nikospapcom marked this pull request as ready for review November 25, 2024 11:12
@panteliselef
Copy link
Member

@nikospapcom don't we also need WaitList as a modal ?

@nikospapcom nikospapcom force-pushed the nikospap/user-1084-support-waitlist-for-astro branch from 9783b86 to dcf50c3 Compare November 25, 2024 15:30
@clerk clerk deleted a comment from clerk-cookie Nov 25, 2024
@nikospapcom
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 1.5.0-snapshot.v20241125153146

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.5.0-snapshot.v20241125153146 --save-exact

Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Re: WaitList as a modal @panteliselef - I don't think there's a separate WaitList modal component in @clerk/clerk-react, but they can use $clerkStore.get().openWaitlist() instead ❓

@nikospapcom
Copy link
Member Author

Looks good!

Re: WaitList as a modal @panteliselef - I don't think there's a separate WaitList modal component in @clerk/clerk-react, but they can use $clerkStore.get().openWaitlist() instead ❓

@wobsoriano we discussed offline with Pantelis and you're right, they can use $clerkStore.get().openWaitlist()

@nikospapcom nikospapcom merged commit aa94dbd into main Nov 25, 2024
27 checks passed
@nikospapcom nikospapcom deleted the nikospap/user-1084-support-waitlist-for-astro branch November 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants