Merge pull request #36 from Mervill/plot-name-cache

Properly cache CStrings for plot names

.gitignore

@@ -2,9 +2,13 @@
 .idea/
 .vscode/
 
+# visual studio
+.vs/
+
 # C# build artifacts
 /bin/
 /obj/
+/artifacts/
 
 # C# packages
 /nupkg/

src/cs/samples/HelloWorld/Profiler.cs

@@ -1,9 +1,15 @@
-using System.Runtime.CompilerServices;
+using System;
+using System.Collections.Generic;
+using System.Runtime.CompilerServices;
 using bottlenoselabs.C2CS.Runtime;
 using static Tracy.PInvoke;
 
 public static class Profiler
 {
+    // Plot names need to be cached for the lifetime of the program
+    // seealso Tracy docs section 3.1
+    private static readonly Dictionary<string, CString> PlotNameCache = new Dictionary<string, CString>();
+
     /// <summary>
     /// Begins a new <see cref="ProfilerZone"/> and returns the handle to that zone. Time
     /// spent inside a zone is calculated by Tracy and shown in the profiler. A zone is
@@ -76,7 +82,7 @@ public static ProfilerZone BeginZone(
     /// </param>
     public static void PlotConfig(string name, PlotType type = PlotType.Number, bool step = false, bool fill = true, uint color = 0)
     {
-        using var namestr = GetCString(name, out var _);
+        var namestr = GetPlotCString(name);
         TracyEmitPlotConfig(namestr, (int)type, step ? 1 : 0, fill ? 1 : 0, color);
     }
 
@@ -85,7 +91,7 @@ public static void PlotConfig(string name, PlotType type = PlotType.Number, bool
     /// </summary>
     public static void Plot(string name, double val)
     {
-        using var namestr = GetCString(name, out var _);
+        var namestr = GetPlotCString(name);
         TracyEmitPlot(namestr, val);
     }
 
@@ -94,7 +100,7 @@ public static void Plot(string name, double val)
     /// </summary>
     public static void Plot(string name, int val)
     {
-        using var namestr = GetCString(name, out var _);
+        var namestr = GetPlotCString(name);
         TracyEmitPlotInt(namestr, val);
     }
 
@@ -103,10 +109,20 @@ public static void Plot(string name, int val)
     /// </summary>
     public static void Plot(string name, float val)
     {
-        using var namestr = GetCString(name, out var _);
+        var namestr = GetPlotCString(name);
         TracyEmitPlotFloat(namestr, val);
     }
 
+    private static CString GetPlotCString(string name)
+    {
+        if(!PlotNameCache.TryGetValue(name, out var plotCString))
+        {
+            plotCString = CString.FromString(name);
+            PlotNameCache.Add(name, plotCString);
+        }
+        return plotCString;
+    }
+
     /// <summary>
     /// Emit the top-level frame marker.
     /// </summary>
@@ -118,6 +134,15 @@ public static void EmitFrameMark()
         TracyEmitFrameMark(null);
     }
 
+    /// <summary>
+    /// Is the app connected to the external profiler?
+    /// </summary>
+    /// <returns></returns>
+    public static bool IsConnected()
+    {
+        return Convert.ToBoolean(TracyConnected());
+    }
+
     /// <summary>
     /// Creates a <seealso cref="CString"/> for use by Tracy. Also returns the
     /// length of the string for interop convenience.

src/cs/samples/HelloWorld/Program.cs

@@ -8,24 +8,26 @@ static void Delay()
         int i, end;
         double j = 0;
 
+        Profiler.PlotConfig("Random", step: true);
+
         using (Profiler.BeginZone("My Custom Event Name"))
         {
-
             Random random = new Random();
 
-            for (i = 0, end = (int)random.NextInt64() / 100; i < end; ++i)
+            var randomValue = (int)random.NextInt64() / 100;
+            for (i = 0, end = randomValue; i < end; ++i)
             {
                 j += Math.Sin(i);
             }
 
+            Profiler.Plot("Random", randomValue);
         }
     }
 
     static void ColoredEvent()
     {
         using (Profiler.BeginZone(color: (uint)ColorType.Aqua))
         {
-
             Thread.Sleep(16);
         }
     }