Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dia.ToolsView): make sure tools are rendered before the first update #2815

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

kumilingus
Copy link
Contributor

Description

PR ensures that update() of tools is called after they are rendered.

paper.freeze();
const remove = new joint.linkTools.Vertices();
const toolsView = new joint.dia.ToolsView({ tools: [remove] });
linkView.addTools(toolsView);
linkView.hideTools();
paper.unfreeze();
// ASSERT: the tools are not rendered yet
linkView.showTools();
// ASSERT: tools are now rendered (previously an update was called without the tools being correctly rendered)

@MartinKanera MartinKanera merged commit 29be243 into clientIO:master Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants