fix frontend issues #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgraue
requested changes
May 24, 2024
| if (data === null) { | ||
| return <div>Loading...</div>; | ||
| return( |
There was a problem hiding this comment.
Result page isn't working for me because of the zipcode bug
There was a problem hiding this comment.
@codeexpert74 This is still an issues
|
I have fixed 54, 59, 63, 64, 65, 66, 67, 70, 72, 73, 74, 75, 76 issues. |
|
Do you mean adding spin to this?
…On Mon, May 27, 2024 at 9:18 AM Ryan Graue ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/pages/Results.jsx
<#80 (comment)>
:
> if (data === null) {
- return <div>Loading...</div>;
+ return(
@codeexpert74 <https://github.com/codeexpert74> This is still an issues
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHSYIXJICEID3U5UY3SULB3ZENMG7AVCNFSM6AAAAABIGCK46SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBRGIZTMMZSHE>
.
You are receiving this because you were mentioned.Message ID:
<climate-cooperative/home-energy-calculator/pull/80/review/2081236329@
github.com>
|
|
What must I do for that one?
…On Mon, May 27, 2024 at 9:48 AM Code Expert ***@***.***> wrote:
Do you mean adding spin to this?
On Mon, May 27, 2024 at 9:18 AM Ryan Graue ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In src/pages/Results.jsx
> <#80 (comment)>
> :
>
> > if (data === null) {
> - return <div>Loading...</div>;
> + return(
>
> @codeexpert74 <https://github.com/codeexpert74> This is still an issues
>
> —
> Reply to this email directly, view it on GitHub
> <#80 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BHSYIXJICEID3U5UY3SULB3ZENMG7AVCNFSM6AAAAABIGCK46SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBRGIZTMMZSHE>
> .
> You are receiving this because you were mentioned.Message ID:
> <climate-cooperative/home-energy-calculator/pull/80/review/2081236329@
> github.com>
>
|
rgraue
approved these changes
May 28, 2024
There was a problem hiding this comment.
@cooper-roper can you give a quick once over too? I had some hand in the work here, so want to have a fresh eye on it. Make sure to run it locally on ur machine to test. Lots of code here...
I'll resolve the convos after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed 54, 59, 63, 64, 65, 66, 67, 70, 72, 73, 74, 75, 76 issues.