Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1238 adjust organization card height #1240

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MarcoRehmer
Copy link
Contributor

What and Why

  • increase the height of organization cards to 390px fix

Additional

  • add "husky" pre-commit hooks and "lint-staged" to only format staged files with prettier (only affects js, ts, jsx, tsx files. Backend files are not be affected by this)
  • add installation steps to README.md

Copy link
Member

@positiveimpact positiveimpact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the the husky pre-commit hook doesn't work yet.
I ran the sh yarn preparecommand in climateconnect/frontend. This creates a climateconnect/frontend/.husky/pre-commit file which looks like this:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"
cd frontend && npm run pre-commit

When making a commit it will fail because this file is in the frontend folder but tries to cd to frontend which is not possible because it's already there so I get this error: frontend/.husky/pre-commit: 5: cd: can't cd to frontend

Also yarn prepare creates a file named .yarn-integrity. We should either commit this file or add it to .gitignore.

@MarcoRehmer
Copy link
Contributor Author

ah yes good catch, also it should not run "npm", instead yarn should be used. I will fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants