Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't transform integer keys #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

harryfb
Copy link

@harryfb harryfb commented Oct 8, 2021

This change allows integer keys to pass through key-transformation unchanged. We often process objects with integer keys and the current implementation makes use of the name built-in clj function, which throws an exception for integer values. See issue #62. Passes all tests okay - let me know if a new test case is required.

@harryfb harryfb requested a review from qerub as a code owner October 8, 2021 10:50
@pratik97
Copy link

@harryfb @qerub should we put this change under a config for backward compatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants