Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompute namespace info on each fighweel-main recompilation #3404

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

vemv
Copy link
Member

@vemv vemv commented Aug 12, 2023

Cheers - V

@vemv vemv requested a review from bbatsov August 12, 2023 18:06
@vemv vemv changed the title Figwheel get state Recompute namespace info on each fighweel-main recompilation Aug 12, 2023
@bbatsov
Copy link
Member

bbatsov commented Aug 18, 2023

The changes look good to me, but you'll need to address the conflict in the changelog. Might also be good at some point to update a bit https://docs.cider.mx/cider/basics/clojurescript.html to reflect the current state of affairs.

Similar to #3396, except that it's only necessary on recompilation - not on evaluations.
@vemv
Copy link
Member Author

vemv commented Aug 18, 2023

Thanks!

The docs look fairly reasonable. There are some changes in master not deployed yet.

Perhaps we can nuke the Boot docs at some point.

...Or maybe hide them under a collapsible widget, if that's possible (over github we have <details>...</details>)

@vemv vemv merged commit 363b8e9 into master Aug 18, 2023
26 checks passed
@vemv vemv deleted the figwheel-get-state branch August 18, 2023 10:18
@bbatsov
Copy link
Member

bbatsov commented Aug 18, 2023

Probably in CIDER 2.0 we should nuke the support for Boot:
image

It's completely dead at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants