Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustments to docstrings #3706

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Conversation

katomuso
Copy link
Contributor

@katomuso katomuso commented Jun 7, 2024

Tweak docstring of cider-sync-request:clojuredocs-lookup as it actually performs clojuredocs-lookup op and not resource op.

Tweak docstrings of cider-var-info and cider-member-info as it seems that what these functions actually return is an nREPL dict and not an alist. Also, I'm not sure what "with list cdrs" means.

@katomuso katomuso changed the title Some minor adjustments Minor adjustments to docstrings Jun 7, 2024
cider-client.el Outdated
@@ -548,7 +548,7 @@ Used only when the info nREPL middleware is not available."
var-info))

(defun cider-var-info (var &optional all)
"Return VAR's info as an alist with list cdrs.
"Return info on VAR as an nREPL dict.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on -> for

cider-client.el Outdated
@@ -559,7 +559,7 @@ unless ALL is truthy."
(if all var-info (cider--var-choice var-info)))))

(defun cider-member-info (class member)
"Return the CLASS MEMBER's info as an alist with list cdrs."
"Return info on MEMBER of CLASS as an nREPL dict."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on -> for

@katomuso
Copy link
Contributor Author

katomuso commented Jun 8, 2024

@bbatsov I've applied the suggested changes.

@bbatsov bbatsov merged commit 09d3dd4 into clojure-emacs:master Jun 8, 2024
38 of 39 checks passed
@bbatsov
Copy link
Member

bbatsov commented Jun 8, 2024

Thanks!

@katomuso katomuso deleted the tweaks branch June 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants