Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GCP to the scale-ci-pipeline #85

Merged
merged 1 commit into from
May 15, 2020

Conversation

mohit-sheth
Copy link
Contributor

No description provided.

Copy link
Member

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Other than that lgtm.

@@ -100,6 +103,11 @@ node (node_label) {
if (openshiftv4_install_on_azure == "TRUE") {
load "pipeline-scripts/openshiftv4_on_azure.groovy"
}

// stage to install openshift 4.x on GCP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed in favor of line 54.

@@ -3,7 +3,7 @@
description: 'Collection of Jenkins jobs to setup osp, ocp and run various scale
tests on OpenShift. '
disabled: false
name: SCALE-CI-PIPELINE
name: scale-ci-pipeline-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep the name as is, scale-ci-pipeline-test is the name of the test job.

OPENSHIFT_WORKER_COUNT=5
OPENSHIFT_MASTER_INSTANCE_TYPE=n1-standard-4
OPENSHIFT_WORKER_INSTANCE_TYPE=n1-standard-4
OPENSHIFT_MASTER_ROOT_VOLUME_SIZE=64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set the defaults to match the installer. Relevant issue: cloud-bulldozer/scale-ci-deploy#72.

@mohit-sheth mohit-sheth force-pushed the gcp_pipeline branch 2 times, most recently from 215c834 to fbcf2e2 Compare May 15, 2020 15:21
Copy link
Member

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitanyaenr
Copy link
Member

@mohit-sheth We need to add info about OCP on GCP install in https://github.com/openshift-scale/scale-ci-pipeline#scale-ci-jobs.

@chaitanyaenr chaitanyaenr merged commit e0a22b4 into cloud-bulldozer:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants