-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GCP to the scale-ci-pipeline #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits. Other than that lgtm.
@@ -100,6 +103,11 @@ node (node_label) { | |||
if (openshiftv4_install_on_azure == "TRUE") { | |||
load "pipeline-scripts/openshiftv4_on_azure.groovy" | |||
} | |||
|
|||
// stage to install openshift 4.x on GCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed in favor of line 54.
jjb/dynamic/scale-ci-pipeline.yml
Outdated
@@ -3,7 +3,7 @@ | |||
description: 'Collection of Jenkins jobs to setup osp, ocp and run various scale | |||
tests on OpenShift. ' | |||
disabled: false | |||
name: SCALE-CI-PIPELINE | |||
name: scale-ci-pipeline-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep the name as is, scale-ci-pipeline-test is the name of the test job.
OPENSHIFT_WORKER_COUNT=5 | ||
OPENSHIFT_MASTER_INSTANCE_TYPE=n1-standard-4 | ||
OPENSHIFT_WORKER_INSTANCE_TYPE=n1-standard-4 | ||
OPENSHIFT_MASTER_ROOT_VOLUME_SIZE=64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's set the defaults to match the installer. Relevant issue: cloud-bulldozer/scale-ci-deploy#72.
215c834
to
fbcf2e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mohit-sheth We need to add info about OCP on GCP install in https://github.com/openshift-scale/scale-ci-pipeline#scale-ci-jobs. |
No description provided.