Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rbac): fix migration issue with multiple admins #5

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix(rbac): fix migration issue with multiple admins #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
129731c
fix(rbac): fix migration issue with multiple admins
PatAKnight Jan 30, 2024
386704c
fix(rbac): remove console log
PatAKnight Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions plugins/rbac-backend/migrations/20231221113214_migrations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,18 @@ exports.up = async function up(knex) {
.where('ptype', 'g')
.then(listGroupPolicies => {
const allGroupPolicies = [];
let rbacFlag = false;
for (const groupPolicy of listGroupPolicies) {
const { v1 } = groupPolicy;
if (v1 === 'role:default/rbac_admin') {
rbacFlag = true;
continue;
}
allGroupPolicies.push(v1);
}
if (rbacFlag) {
allGroupPolicies.push('role:default/rbac_admin');
}
return allGroupPolicies;
});
}
Expand Down
Loading