Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix plan visibility for production #322

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix plan visibility for production #322

merged 1 commit into from
Apr 12, 2024

Conversation

bengerman13
Copy link
Contributor

Changes proposed in this pull request:

  • fix plan visibility for production
  • drop check-yaml pre-commit since it doesn't understand our anchors

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@bengerman13 bengerman13 requested a review from a team April 12, 2024 00:09
@soutenniza soutenniza merged commit 89028b4 into main Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutenniza soutenniza soutenniza approved these changes

@ChrisMcGowan ChrisMcGowan ChrisMcGowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bengerman13 @soutenniza @ChrisMcGowan