Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bb/better dedicated alb sourcing #325

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Bb/better dedicated alb sourcing #325

merged 4 commits into from
Apr 18, 2024

Conversation

bengerman13
Copy link
Contributor

Changes proposed in this pull request:

  • dedicate a new ALB to an org when too few slots are left on the existing ALB
  • fix some comments
  • use sqlalchemy.null instead of None so we can shake some # noqas

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@bengerman13 bengerman13 requested a review from a team April 18, 2024 17:07
markdboyd
markdboyd reviewed Apr 18, 2024
View reviewed changes
broker/config.py Outdated Show resolved Hide resolved
@bengerman13 bengerman13 merged commit efcd45a into main Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdboyd markdboyd markdboyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengerman13 @markdboyd