Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden image #373

Merged
merged 10 commits into from
Sep 9, 2024
Merged

Harden image #373

merged 10 commits into from
Sep 9, 2024

Conversation

dandersonsw
Copy link
Contributor

Changes proposed in this pull request:

  • Update docker image to use our hardened base image
  • Update pipeline to use the hardened testing image

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Using hardened images

@dandersonsw dandersonsw requested a review from a team as a code owner September 9, 2024 17:13
@dandersonsw dandersonsw merged commit fa9ebad into main Sep 9, 2024
1 check passed
@dandersonsw dandersonsw deleted the harden-image branch September 9, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdboyd markdboyd markdboyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandersonsw @markdboyd