chore: refactor setting step description, etc, to common code #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdboyd
previously approved these changes
Sep 23, 2024
markdboyd
reviewed
Sep 23, 2024
broker/tasks/cloudwatch.py
Outdated
| def delete_health_check_alarms(operation_id: int, **kwargs): | ||
| operation = db.session.get(Operation, operation_id) | ||
| @pipeline_operation("Updating Cloudwatch alarms for Route53 health checks") | ||
| def update_health_check_alarms(operation_id: int, *, operation, db, **kwargs): |
There was a problem hiding this comment.
This task should be removed
markdboyd
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Things to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
None