osmorphing: Fix undefined attribute installed_packages

cloudbase · Sep 24, 2024 · 143075b · 143075b
1 parent fd011f0
commit 143075b
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 6 deletions.
diff --git a/coriolis/osmorphing/base.py b/coriolis/osmorphing/base.py
@@ -79,7 +79,7 @@ def check_os_supported(cls, detected_os_info):
                 cls.__name__))
 
     @abc.abstractmethod
-    def get_installed_packages(self, package_name):
+    def get_installed_packages(self):
         pass
 
     @abc.abstractmethod
@@ -125,7 +125,6 @@ def set_environment(self, environment):
 class BaseLinuxOSMorphingTools(BaseOSMorphingTools):
 
     _packages = {}
-    installed_packages = []
 
     def __init__(self, conn, os_root_dir, os_root_dev, hypervisor,
                  event_manager, detected_os_info, osmorphing_parameters,

diff --git a/coriolis/osmorphing/coreos.py b/coriolis/osmorphing/coreos.py
@@ -15,7 +15,7 @@ def check_os_supported(cls, detected_os_info):
         return False
 
     def get_installed_package(self):
-        pass
+        self.installed_packages = []
 
     def disable_predictable_nic_names(self):
         pass

diff --git a/coriolis/osmorphing/debian.py b/coriolis/osmorphing/debian.py
@@ -128,7 +128,7 @@ def get_installed_packages(self):
             self.installed_packages = self._exec_cmd_chroot(
                 cmd).decode('utf-8').splitlines()
         except exception.CoriolisException:
-            pass
+            self.installed_packages = []
 
     def pre_packages_install(self, package_names):
         super(BaseDebianMorphingTools, self).pre_packages_install(

diff --git a/coriolis/osmorphing/openwrt.py b/coriolis/osmorphing/openwrt.py
@@ -18,7 +18,7 @@ def check_os_supported(cls, detected_os_info):
         return False
 
     def get_installed_package(self):
-        pass
+        self.installed_packages = []
 
     def disable_predictable_nic_names(self):
         pass

diff --git a/coriolis/osmorphing/redhat.py b/coriolis/osmorphing/redhat.py
@@ -217,6 +217,7 @@ def get_installed_packages(self):
         except exception.CoriolisException:
             LOG.warning("Failed to get installed packages")
             LOG.trace(utils.get_exception_details())
+            self.installed_packages = []
 
     def _yum_install(self, package_names, enable_repos=[]):
         try:

diff --git a/coriolis/osmorphing/suse.py b/coriolis/osmorphing/suse.py
@@ -73,6 +73,7 @@ def get_installed_packages(self):
         except exception.CoriolisException:
             LOG.warning("Failed to get installed packages")
             LOG.trace(utils.get_exception_details())
+            self.installed_packages = []
 
     def get_update_grub2_command(self):
         location = self._get_grub2_cfg_location()

diff --git a/coriolis/osmorphing/windows.py b/coriolis/osmorphing/windows.py
@@ -611,7 +611,7 @@ def get_packages(self):
         return [], []
 
     def get_installed_packages(self):
-        pass
+        self.installed_packages = []
 
     def pre_packages_install(self, package_names):
         pass