Add unit tests for Minion Manager RPC Server #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiclea
force-pushed
the
test-minion-manager
branch
2 times, most recently
from
0cfd1bf to
e62e76f
Compare
smiclea
force-pushed
the
test-minion-manager
branch
from
e62e76f to
1d0e33c
Compare
smiclea
force-pushed
the
test-minion-manager
branch
from
1d0e33c to
a2abaef
Compare
|
@Dany9966 I removed the manual exception mappings using |
Dany9966
requested changes
Nov 9, 2023
coriolis/tests/minion_manager/rpc/data/validate_minion_pool_selections_for_action_config.yaml
Show resolved
Hide resolved
smiclea
force-pushed
the
test-minion-manager
branch
6 times, most recently
from
f4d8b77 to
9189250
Compare
|
@Dany9966 All changes from conversions marked as resolved are now pushed |
Dany9966
requested changes
Nov 15, 2023
coriolis/tests/minion_manager/rpc/data/validate_minion_pool_selections_for_action_config.yaml
Show resolved
Hide resolved
coriolis/tests/minion_manager/rpc/data/make_minion_machine_allocation_subflow_for_action.yaml
Show resolved
Hide resolved
coriolis/tests/minion_manager/rpc/data/get_minion_pool_refresh_flow.yaml
Show resolved
Hide resolved
coriolis/tests/minion_manager/rpc/data/get_minion_pool_refresh_flow.yaml
Show resolved
Hide resolved
coriolis/tests/minion_manager/rpc/data/get_minion_pool_refresh_flow.yaml
Outdated
Show resolved
Hide resolved
coriolis/tests/minion_manager/rpc/data/get_minion_pool_refresh_flow.yaml
Outdated
Show resolved
Hide resolved
smiclea
force-pushed
the
test-minion-manager
branch
from
9189250 to
8ee1eb0
Compare
|
@Dany9966 All conversations have been resolved. |
smiclea
force-pushed
the
test-minion-manager
branch
from
8ee1eb0 to
343dbe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.