Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests for coriolis main modules #287

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Add more unit tests for coriolis main modules #287

merged 7 commits into from
Jan 31, 2024

Conversation

mihaelabalutoiu
Copy link
Contributor

@mihaelabalutoiu mihaelabalutoiu commented Jan 12, 2024 •
edited
Loading

This PR adds more unit testing for the following modules:

  • rpc.py
  • schemas.py
  • secrets.py
  • service.py
  • utils.py
  • wsman.py

@mihaelabalutoiu mihaelabalutoiu force-pushed the add-more-unit-tests branch 2 times, most recently from c0e4651 to 38acee0 Compare January 15, 2024 11:10
Dany9966
Dany9966 requested changes Jan 29, 2024
View reviewed changes
coriolis/tests/test_rpc.py Outdated Show resolved Hide resolved
coriolis/tests/test_rpc.py Show resolved Hide resolved
coriolis/tests/test_rpc.py Outdated Show resolved Hide resolved
coriolis/tests/test_rpc.py Outdated Show resolved Hide resolved
coriolis/tests/test_rpc.py Outdated Show resolved Hide resolved
coriolis/tests/test_wsman.py Show resolved Hide resolved
coriolis/tests/test_wsman.py Show resolved Hide resolved
coriolis/tests/test_wsman.py Show resolved Hide resolved
coriolis/tests/test_wsman.py Outdated Show resolved Hide resolved
coriolis/tests/test_wsman.py Outdated Show resolved Hide resolved
mihaelabalutoiu
mihaelabalutoiu commented Jan 30, 2024
View reviewed changes
Copy link
Contributor Author

@mihaelabalutoiu mihaelabalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dany9966 I updated the code, take a look now! Thank you!

coriolis/tests/test_rpc.py Outdated Show resolved Hide resolved
coriolis/tests/test_rpc.py Show resolved Hide resolved
coriolis/tests/test_service.py Outdated Show resolved Hide resolved
coriolis/tests/test_utils.py Outdated Show resolved Hide resolved
coriolis/tests/test_utils.py Outdated Show resolved Hide resolved
coriolis/tests/test_utils.py Outdated Show resolved Hide resolved
@mihaelabalutoiu
Add unit tests for the rpc.py module
17bd7b9 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add full coverage for the schemas.py module
6f46357 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for the secrets.py module
81f4449 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for the service.py module
cac08f3 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Dany9966
Dany9966 requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@Dany9966 Dany9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit. Will merge afterwards.

coriolis/tests/test_utils.py Outdated Show resolved Hide resolved
coriolis/tests/test_utils.py Outdated Show resolved Hide resolved
@mihaelabalutoiu
Add unit tests for the utils.py module
827aa2d 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for the wsman.py module
a5351e1 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Updated get_ssl_cert_thumbprint to allow
766d34a 
customizable digest algorithms

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Copy link
Contributor Author

Just a small nit. Will merge afterwards.

Done, thank you!

@Dany9966 Dany9966 merged commit ae91850 into cloudbase:master Jan 31, 2024
4 checks passed
@mihaelabalutoiu mihaelabalutoiu deleted the add-more-unit-tests branch January 31, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dany9966 Dany9966 Dany9966 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaelabalutoiu @Dany9966