Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for coriolis/taskflow modules #288

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

mihaelabalutoiu
Copy link
Contributor

This PR adds unit tests for the following modules:

  • taskflow/runner.py
  • taskflow/utils.py
  • taskflow/base.py

@mihaelabalutoiu mihaelabalutoiu force-pushed the add-taskflow-unit-tests branch from ddc1f1f to 1df3758 Compare January 22, 2024 13:02
coriolis/tests/taskflow/test_runner.py Outdated Show resolved Hide resolved
coriolis/tests/taskflow/test_runner.py Outdated Show resolved Hide resolved
coriolis/tests/taskflow/test_runner.py Outdated Show resolved Hide resolved
coriolis/tests/taskflow/test_runner.py Show resolved Hide resolved
coriolis/tests/taskflow/test_runner.py Show resolved Hide resolved
coriolis/tests/taskflow/test_base.py Outdated Show resolved Hide resolved
coriolis/tests/taskflow/test_base.py Outdated Show resolved Hide resolved
coriolis/tests/taskflow/test_base.py Outdated Show resolved Hide resolved
coriolis/tests/taskflow/test_base.py Outdated Show resolved Hide resolved
coriolis/tests/taskflow/test_base.py Outdated Show resolved Hide resolved
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
for the current module.

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Copy link
Contributor Author

Done. I made the changes. Please take a look now, thanks.

Copy link
Contributor

@Dany9966 Dany9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dany9966 Dany9966 merged commit be04678 into cloudbase:master Feb 21, 2024
4 checks passed
@mihaelabalutoiu mihaelabalutoiu deleted the add-taskflow-unit-tests branch February 27, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants