Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for coriolis/scheduler and coriolis/services modules #290

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Add unit tests for coriolis/scheduler and coriolis/services modules #290

merged 6 commits into from
Feb 28, 2024

Conversation

mihaelabalutoiu
Copy link
Contributor

This PR adds unit tests for the following modules:

  • services/api.py
  • scheduler/scheduler_utils.py
  • scheduler/rpc/client.py
  • scheduler/rpc/server.py
  • scheduler/filters/base.py
  • scheduler/filters/trivial_filters.py

@mihaelabalutoiu mihaelabalutoiu force-pushed the add-services-scheduler-unit-tests branch from f9873ef to db4deec Compare January 26, 2024 11:50
Dany9966
Dany9966 requested changes Feb 26, 2024
View reviewed changes
coriolis/tests/scheduler/filters/test_trivial_filters.py Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Outdated Show resolved Hide resolved
Dany9966
Dany9966 requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Dany9966 Dany9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general note, can you please start using 2024 as your copyright year at the start of your new files?

coriolis/tests/scheduler/rpc/test_server.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_server.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_server.py Show resolved Hide resolved
coriolis/tests/scheduler/test_scheduler_utils.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/test_scheduler_utils.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/test_scheduler_utils.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/test_scheduler_utils.py Outdated Show resolved Hide resolved
@mihaelabalutoiu
Add unit tests for services/api.py module
d40e8cb 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu mihaelabalutoiu force-pushed the add-services-scheduler-unit-tests branch from db4deec to 52d21e7 Compare February 27, 2024 19:50
@mihaelabalutoiu
Copy link
Contributor Author

Thanks a lot, I updated the code, please take a look now. :)

@mihaelabalutoiu
Add unit tests for scheduler/scheduler_utils.py
c0a4845 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu mihaelabalutoiu force-pushed the add-services-scheduler-unit-tests branch from 52d21e7 to 278ea6d Compare February 28, 2024 13:51
@mihaelabalutoiu mihaelabalutoiu force-pushed the add-services-scheduler-unit-tests branch from 278ea6d to 565095c Compare February 28, 2024 13:58
Dany9966
Dany9966 reviewed Feb 28, 2024
View reviewed changes
coriolis/tests/scheduler/rpc/test_client.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Outdated Show resolved Hide resolved
coriolis/tests/scheduler/rpc/test_client.py Outdated Show resolved Hide resolved
@mihaelabalutoiu mihaelabalutoiu force-pushed the add-services-scheduler-unit-tests branch from 565095c to 51c8434 Compare February 28, 2024 14:38
@mihaelabalutoiu
Add unit tests for scheduler/rpc/client.py
beb2e8e 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add full coverage for the scheduler/rpc/server.py
aab799b 
module
@mihaelabalutoiu
Add unit tests for scheduler/filters/base.py
90dbc0a 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for scheduler/filters/trivial_filters.py
901115d 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu mihaelabalutoiu force-pushed the add-services-scheduler-unit-tests branch from 51c8434 to 901115d Compare February 28, 2024 14:47
@Dany9966 Dany9966 merged commit 1b4a541 into cloudbase:master Feb 28, 2024
4 checks passed
@mihaelabalutoiu mihaelabalutoiu deleted the add-services-scheduler-unit-tests branch February 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dany9966 Dany9966 Dany9966 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaelabalutoiu @Dany9966