Fix licensing client error logging #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dany9966
requested changes
Jul 17, 2024
|
|
||
| mock_response.raise_for_status.assert_called_once() | ||
|
|
||
| mock_response = self.setup_mock_response(mock_post) |
There was a problem hiding this comment.
Wasn't this supposed to setup the Exception side_effect?
| {'error': {'code': 409, 'message': 'test_message'}} | ||
| ) | ||
| mock_raise_response_error.assert_called_once_with(mock_response) | ||
| mock_response.raise_for_status.assert_not_called() |
There was a problem hiding this comment.
Is there any raise_for_status call in _do_req we should be concerned about?
| @@ -405,4 +477,4 @@ def test_delete_reservation(self, mock_do_req): | |||
| 'delete', '/reservations/%s' % self.reservation_id, | |||
| raw_response=True | |||
| ) | |||
| mock_response.raise_for_status.assert_called_once() | |||
| mock_raise_response_error.assert_called_once_with(mock_response) | |||
There was a problem hiding this comment.
Please also add a case for delete_reservation where the response if not ok, and the error code is different from 404.
Cristi1324
force-pushed
the
fix_licensing_error_log
branch
3 times, most recently
from
c470666 to
a062898
Compare
Cristi1324
force-pushed
the
fix_licensing_error_log
branch
from
a062898 to
6160f71
Compare
Dany9966
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes error log in licensing client when deleting reservation.