[OSMorphing] Add check for installed package #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dany9966
reviewed
Aug 20, 2024
coriolis/osmorphing/redhat.py
Outdated
| try: | ||
| self._exec_cmd_chroot(cmd) | ||
| return True | ||
| except Exception: |
There was a problem hiding this comment.
This exception is too broad. Normally, we'd only like to catch whether a command fails, this catches any error. Please replace this with CoriolisException (this is what is raised if a command fails). Also, please add a log message:
LOG.warning(f"Package ${package_name} is not installed")
LOG.trace(utils.get_exception_details())
Cristi1324
force-pushed
the
check_grubby_installed
branch
from
0b1b9e2 to
d8abfcb
Compare
Dany9966
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add check for installed package and checks that grubby is installed before trying to install it.