Adding unit-tests and json schema validation

[fabi200123]

• Adding json schema validation for extra specs
• Adding unit-tests

[gabriel-samfira]

I get why this change is made, but keep in mind that people are already using the old naming. Changing this will break their pools when they update.

[fabi200123]

In the code itself it's allowed_image_owners, but in the Readme was allow_image_owners. Which one should we stick to then?

[gabriel-samfira]

ohh! The one in the code. Aesthetics matter less. We don't want to change functionality for the sake of aesthetics, but if the code is okay and the README has a typo, ignore me.

[gabriel-samfira]

I think this can be a NewTestOpenStackClient() that creates a proper testing client instead of replacing individual service clients inside the already instantiated one.

You can then replace the old one with the one returned here:

func NewTestOpenStackClient(mockClient *gophercloud.ServiceClient, controllerID string) *OpenstackClient {
    return &OpenstackClient{
		compute:      mockClient,
		image:        mockClient,
		network:      mockClient,
		volume:       mockClient,
		controllerID: controllerID,
	}
}

And then later in your code, you can just:

serviceClient := thclient.ServiceClient()
mockCli := NewTestOpenStackClient(serviceClient, "my-controller-id")
provider.cli = mockCli

[fabi200123]

This is indeed better! Updated it!

[gabriel-samfira]

This should probably be moved to the _test.go file.

[fabi200123]

From what I have tried before, the functions under file_test.go will not be seen by go as part of that package. So, if I move that function to client_test.go, it wont be seen by the provider.go (where it is used) as part of the client package

[gabriel-samfira]

you can use something like this:

https://github.com/cloudbase/garm/blob/6e416bb4947380735771bd1234b90fe63c6e46d4/internal/testing/testing.go#L15-L16

and pass that tag when running the tests:

https://github.com/cloudbase/garm/blob/6e416bb4947380735771bd1234b90fe63c6e46d4/Makefile#L91

The idea is to only make that function available during testing.

[fabi200123]

Created a new file testing.go in the client package that is accessed only by the flag testing.