Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken if comparison #165

Merged

Conversation

gabriel-samfira
Copy link
Member

@gabriel-samfira gabriel-samfira commented Dec 16, 2024

PowerShell considers the integer 0 as a false value when used in an if statement. We need to explicitly compare the result to $null.

Fixes: #164

PowerShell considers the integer 0 as a false value when used in an if
statement. We need to explicitly compare the result to $null.

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
@gabriel-samfira gabriel-samfira merged commit 352d6b0 into cloudbase:master Dec 16, 2024
7 checks passed
@gabriel-samfira gabriel-samfira deleted the fix-casting-zero-as-bigint branch December 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING] 0 is converted to BigInteger rather than Int32 in v0.49
1 participant