Use decimal as first option when parsing floats #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decimals offer much greater precission as opposed to double at the cost of performance. However, in most cases, precission is desirable. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
amis92
reviewed
Dec 18, 2024
| @@ -711,11 +712,19 @@ int64: 9223372036854775807 | |||
| $result.bigInt | Should -BeOfType System.Numerics.BigInteger | |||
| } | |||
|
|
|||
| It "Should round-trip decimals with trailing 0" { | |||
| $result = ConvertFrom-Yaml -Yaml $value | |||
| $result.decimal | Should -Be ([decimal]3.10) | |||
There was a problem hiding this comment.
I'd add a test for .Scale here.
The [decimal]3.10 is not really working in PowerShell as you might expect - this firstly creates a double literal, and then that is converted to decimal object. So in reality, the [decimal]3.10 would have Scale=1 and will print (via ToString e.g.) as 3.1. If you construct decimal via explicit Parsing though, it will correctly have Scale=2. See:
$scaletest = '3.9999999999999990'
[decimal]3.9999999999999990
# prints 4
[decimal]$scaletest
# prints 4
[decimal]::Parse($scaletest, [cultureinfo]::InvariantCulture)
# prints `3.9999999999999990`
|
Saw it too late, but it's a comment on test only, and doesn't really change much. Most important test of round-trip works as expected. Great change, thank you! |
|
adding a few more test cases, which will include this one as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decimals offer much greater precission as opposed to double at the cost of performance. However, in most cases, precission is desirable.
Thanks @amis92 !
Fixes: #152