LITE-28666 search by parameter value was fixed #91
Conversation
zzzevaka
commented
Sep 21, 2023
zzzevaka
commented
- search by parameter value was fixed
- ignore FF requests without changes in case of duplications
| if not attempts_left: | ||
| raise | ||
| continue | ||
| result = await self.retrieve_ff_requests(lookup) |
There was a problem hiding this comment.
Can you please clarify why you decided to remove retries?
There was a problem hiding this comment.
This timeout was needed because the Connect client wasn't retrying in case of connection errors.
It was fixed cloudblue/connect-python-openapi-client#74
What I forgot to do is bump the requirements to apply this patch.
This retry should be also deleted in subscriptions lookup. I will do it a bit later.
| for request in requests: | ||
| changed = False | ||
| for item_data in request['asset']['items']: | ||
| if item_data['quantity'] != item_data['old_quantity']: |
There was a problem hiding this comment.
I'm not sure that this will work for 100% of scenarios. Can it be 2 request found and both are SYNC? If yes, we will get an empty result.
There was a problem hiding this comment.
Yes, this is theoretically possible. Thanks!
|
Have just 2 questions. In general everything is good. Thank for adding old_quantity item field, it will be helpful |
ignore FF requests without changes in case of duplications ignore FF requests that was approved after batch.context.period.end
zzzevaka
force-pushed
the
feature/LITE-28666_ff-lookup
branch
from
becd350 to
17051ec
Compare
