Create autocomplete component #102
Conversation
| type: String, | ||
| default: '', | ||
| }, | ||
| optionTextFn: { |
There was a problem hiding this comment.
It was not, deleted. Thanks!
| type: Function, | ||
| default: null, | ||
| }, | ||
| propText: { |
There was a problem hiding this comment.
would be better to name it propId
There was a problem hiding this comment.
although it matches ui-select interface :-)
There was a problem hiding this comment.
If our options are passed as array of objects, this prop is used for deciding which key should be used to display the text so in my opinion makes sense to be named like this. The default 'id' value may be replaced by 'name', 'label' etc, then calling it propId could be more confusing
There was a problem hiding this comment.
But there is another one called propValue having the same idea, where we decide which key from same object will be used as a value of the selected element. Maybe the naming is not perfect, but it captures ok what is this prop used for, plus anyway as you mentioned it matches the 'select' and I prefer to keep consistency :)
There was a problem hiding this comment.
okay, you are right I think it should be changed in both places, maybe later. because it's a key, it should be unique.
paulinaczybir
force-pushed
the
LITE-30695-create-autocomplete-component
branch
from
30dbad1 to
33b2ea9
Compare
|
UI reviewed with Max T.