Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LITE-30797 Adjustments in autocomplete #104

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

paulinaczybir
Copy link
Collaborator

No description provided.

() => model,
(newValue) => {
/* eslint-disable-next-line */
console.log('watch in select', newValue.value);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line

@@ -168,6 +168,16 @@ const getDisplayText = (item) => {
if (props.optionTextFn) return props.optionTextFn(item);
return item[props.propText];
};

watch(
() => model,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need a function here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

await wrapper.setProps({ modelValue: '2' });

/* eslint-disable-next-line */
console.log('model value', modelValue);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

@paulinaczybir paulinaczybir changed the title [X]LITE-30797 Adjustments in autocomplete LITE-30797 Adjustments in autocomplete Aug 22, 2024
@paulinaczybir paulinaczybir force-pushed the LITE-30797-adjustments-in-autocomplete branch from 690e28c to 52666db Compare August 22, 2024 14:29
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 95%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@arnaugiralt arnaugiralt merged commit 06512c4 into master Aug 22, 2024
6 of 9 checks passed
@arnaugiralt arnaugiralt deleted the LITE-30797-adjustments-in-autocomplete branch August 22, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants