Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple dialog #88

Merged
merged 1 commit into from
May 8, 2024
Merged

Add simple dialog #88

merged 1 commit into from
May 8, 2024

Conversation

nerimartinez
Copy link
Collaborator

@nerimartinez nerimartinez commented May 6, 2024

image

Copy link
Collaborator

@paulinaczybir paulinaczybir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please check it out why in documentation tab we don't see the dialog correctly??

Screenshot 2024-05-07 at 15 23 54

@arnaugiralt
Copy link
Member

could you please check it out why in documentation tab we don't see the dialog correctly??

Screenshot 2024-05-07 at 15 23 54

yep, also the title is displayed with weird margins in the storybook, I guess that's because we need to set the margin to 0.

Copy link

sonarqubecloud bot commented May 8, 2024

@arnaugiralt arnaugiralt merged commit 50b0042 into master May 8, 2024
10 of 12 checks passed
@arnaugiralt arnaugiralt deleted the dialog branch May 8, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants