CB-27475 Cleaning up express onboarding outputs #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daszabo
commented
Oct 24, 2024
daszabo
commented
- Cleaned up script outputs
- Made changes so that the scripts should be idempotent now
- Updated the S3 uploader GitHub workflow, to also upload the destroy scripts
jimright
requested changes
Oct 24, 2024
| @@ -59,4 +59,5 @@ jobs: | |||
| for csp in aws azure gcp | |||
| do | |||
| aws s3 cp ${csp}/quickstart.sh s3://${{ vars.S3_BUCKET }}/${csp}/${{ env.S3_FOLDER }}/ | |||
| aws s3 cp ${csp}/destroy.sh s3://${{ vars.S3_BUCKET }}/${csp}/${{ env.S3_FOLDER }}/ | |||
There was a problem hiding this comment.
Ooops, I have this in main but forgot to add here. We should rebase the eob-devel branch onto main at some point to get everything aligned.
There was a problem hiding this comment.
Oh, I didn't notice. I agree we should rebase this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.