Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update env_idbroker return value to 'idbroker' from 'mappings' #92

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Update env_idbroker return value to 'idbroker' from 'mappings' #92

merged 2 commits into from
Nov 2, 2023

Conversation

wmudge
Copy link
Member

@wmudge wmudge commented Mar 21, 2023

No description provided.

@wmudge wmudge added the bug Something isn't working label Mar 21, 2023
@wmudge wmudge requested a review from a team March 21, 2023 22:02
@github-actions github-actions bot added the validated The pull request is passed the prechecks label Mar 21, 2023
@wmudge wmudge requested review from a team and removed request for a team April 17, 2023 18:59
@wmudge wmudge force-pushed the update/env_idbroker_return_value branch from 1e23891 to 840e1d4 Compare April 17, 2023 20:41
@github-actions github-actions bot added validated The pull request is passed the prechecks and removed validated The pull request is passed the prechecks labels Apr 17, 2023
@wmudge wmudge requested review from a team and removed request for a team June 7, 2023 14:07
@wmudge wmudge marked this pull request as draft June 15, 2023 13:23
@wmudge wmudge added this to the Release 2.1.0 milestone Oct 5, 2023
wmudge added 2 commits November 2, 2023 14:47
@wmudge
Update env_idbroker return value to 'idbroker' from 'mappings'
937c859 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Keep legacy return key, 'mappings'.
2113ba5 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge wmudge force-pushed the update/env_idbroker_return_value branch from 840e1d4 to 2113ba5 Compare November 2, 2023 18:53
@github-actions github-actions bot removed the validated The pull request is passed the prechecks label Nov 2, 2023
@wmudge wmudge marked this pull request as ready for review November 2, 2023 18:54
@github-actions github-actions bot added validated The pull request is passed the prechecks and removed validated The pull request is passed the prechecks labels Nov 2, 2023
jimright
jimright approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@wmudge wmudge merged commit 7e48203 into cloudera-labs:devel Nov 2, 2023
5 checks passed
@wmudge wmudge deleted the update/env_idbroker_return_value branch November 2, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimright jimright jimright approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
Release 2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wmudge @jimright