-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PHP 8 #539
Support for PHP 8 #539
Conversation
|
Co-authored-by: Léo Colombaro <git@colombaro.fr>
Mentioning @aseure, just in case 😊 |
Any time to review ? |
Hey @Korben00 and @LeoColomb. Thank you very much for the contribution and your time here. While we would like to better support PHP 8 in the future, an important user base of this plugin is using PHP 7 installation. Even though this version is indeed outdated, and many Wordpress users would gladly upgrade to PHP 8 (or already did), a non-negligible amount of users will still be using PHP 7 (either because they don't know how to upgrade or because their hosted Wordpress will not upgrade). Due to this and the fact that most users have the plugin auto-upgrade setting enable, I'm concerned about breaking their installations. I'll let @jacobbednarz comment on this, who perhaps have more insights than I have on this. cc @william-woodhead as well. |
Indeed, standard practice still today is to keep at least PHP 7.4 in play. |
@aseure @lkraav Thanks for your replies. Thus, we've just submitted another PR (#541) which does not touch the platform version but allows working around the compatibility/conflict issue with the dependencies. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
This pull request includes updates to transition the project's PHP support to version 8.0. These changes are necessary to ensure the project stays compatible with the latest PHP version, providing improved performance, security, and newer language features. The update involves modifications to composer.json, composer.lock, and readme.txt files, alongside code adjustments in src/Integration/DefaultLogger.php to align with PHP 8 standards.
Changes
1. composer.json and composer.lock:
2. src/Integration/DefaultLogger.php:
3. readme.txt: