Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Denise Peña <75506267+dcpena@users.noreply.github.com>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Sep 23, 2024
1 parent d11b947 commit 2783e36
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions src/content/docs/workers/configuration/assets.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Asset hosting on Cloudflare Workers allows developers to run frontend websites

## Configuration

Configuring a project with assets requires specifying a [directory](/workers/configuration/assets/#directory) and an optional [assets binding](/workers/configuration/assets/#binding) in the `wrangler.toml file`. Each Worker is limited to only one set of assets.
Configuring a project with assets requires specifying a [directory](/workers/configuration/assets/#directory) and an optional [assets binding](/workers/configuration/assets/#binding) in the `wrangler.toml` file. Each Worker is limited to only one set of assets.

### Directory

Expand Down Expand Up @@ -102,7 +102,7 @@ Assets are served based on file-based routing. The structure and organization of
If a request does not match an asset based on file-based routing, files are served based on the configuration options defined. There are two areas of asset handling that can be configured:
1. **`html_handling`**: Trailing slashes on websites (e.g. example.com/page/ vs. example.com/page) can impact SEO because search engines treat URLs with and without trailing slashes as different, separate pages. This distinction can lead to duplicate content issues, indexing problems, and overall confusion about the correct canonical version of a page.
1. **`html_handling`**: Trailing slashes on websites (for example, example.com/page/ vs. example.com/page) can impact SEO because search engines treat URLs with and without trailing slashes as different, separate pages. This distinction can lead to duplicate content issues, indexing problems, and overall confusion about the correct canonical version of a page.
`html_handling` configuration determines redirects/rewrites of requests for HTML content. It is used to specify handling that redirects non-canonical URLs to canonical ones, and writes the asset path to serve the expected content at those canonical URLs.
Expand Down Expand Up @@ -156,7 +156,7 @@ Based on the incoming requests, the following assets would be served:
```
Alternate configuration options are outlined on this page and can be specified in your project's wrangler.toml file. If you're deploying using a Framework[link], these options will be defined by the Framework provider.
Alternate configuration options are outlined on this page and can be specified in your project's Wrangler.toml file. If you're deploying using a Framework[link], these options will be defined by the Framework provider.
### html_handling
Expand Down Expand Up @@ -246,7 +246,7 @@ Based on the incoming requests, the following assets would be served:
/foo/bar/cat/dog -> 404 /404.html
```
Define a custom page to be displayed when there is no match for the requested file by creating a 404.html file. If one is not found in the same directory as the route you are currently requesting, it will continue to look up the directory tree for a matching 404.html file. This means that you can define custom 404 paths for situations like /blog/404.html and /404.html, and Workers will automatically render the correct one depending on the situation.
Define a custom page to be displayed when there is no match for the requested file by creating a 404.html` file. If one is not found in the same directory as the route you are currently requesting, it will continue to look up the directory tree for a matching 404.html file. This means that you can define custom 404 paths for situations like `/blog/404.html and /404.html`, and Workers will automatically render the correct one depending on the situation.
**Full-stack Application**
Expand Down
10 changes: 5 additions & 5 deletions src/content/docs/workers/frameworks/get-started.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ This guide will instruct you through setting up and deploying a static site or a

Alternativley, you use can a number of popular frameworks(LINK) that come with ready-to-use components, a pre-defined structured architecture, and community support. View framework specific guides(LINK) to get started using a framework.

# Deploying a Static Site
## Deploy a static site

This guide will instruct you through setting up and deploying a static site on Workers.

Expand Down Expand Up @@ -57,7 +57,7 @@ After you have created your Worker, run the [`wrangler dev`](/workers/wrangler/c
npx wrangler dev
```

### 3. Deploy your Project
### 3. Deploy your project

Deploy your Worker via Wrangler to a `*.workers.dev` subdomain or configure a [Custom Domain](/workers/configuration/routing/custom-domains/).

Expand All @@ -67,11 +67,11 @@ npx wrangler deploy

:::note

Learn about how assets are configured and how routing works: [asset configuration](/workers/configuration/assets/)
Learn about how assets are configured and how routing works from [Assets configuration](/workers/configuration/assets/)

:::

# Deploying a full-stack application
## Deploy a full-stack application

This guide will instruct you through setting up and deploying dynamic and interactive server-side rendered (SSR) applications on Cloudflare Workers.

Expand Down Expand Up @@ -117,6 +117,6 @@ npx wrangler deploy

:::note

Learn about how assets are configured and how routing works: [asset configuration](/workers/configuration/assets/)
Learn about how assets are configured and how routing works from [Assets configuration](/workers/configuration/assets/).

:::

0 comments on commit 2783e36

Please sign in to comment.