Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pulumi] Tutorial updates #16829

Merged
merged 17 commits into from
Sep 24, 2024

Conversation

desteves
Copy link
Contributor

@desteves desteves commented Sep 13, 2024

Summary

Modifies existing tutorials:

  • Add multi-language support to the "Deploy a worker" tutorial
  • Fixes the outline markdown headers
  • Adds consistent flow of steps across the tutorials
  • Adds explanation of newly introduced terms, given these are beginner tutorials
  • Updates metadata
  • Updates deprecated resources and resource inputs in the code snippets

All code has been tested in my local environment

Screenshots (optional)

Documentation checklist

@desteves desteves marked this pull request as ready for review September 13, 2024 18:22
@desteves desteves requested review from kodster28 and a team as code owners September 13, 2024 18:22
@desteves
Copy link
Contributor Author

Unsure why https://www.cloudflare.com/sign-up reports a 403 for the link check.

@kodster28
Copy link
Contributor

Unsure why https://www.cloudflare.com/sign-up reports a 403 for the link check.

That's b/c I think it gets blocked by Turnstile so it doesn't resolve correctly.

cc: @bllchmbrs, do we have a way to update our config with ignored links?

@bllchmbrs
Copy link
Contributor

bllchmbrs commented Sep 16, 2024

@kodster28 , yup, we're aware!

3 things:

  1. We're going to treat these as "success" for you all.
  2. It'd be good to get a "user-agent" that we can share with you so that we get real status code.
  3. We don't "fail" the check yet, because we're working through these. Should finish this week.

@kodster28
Copy link
Contributor

kodster28 commented Sep 17, 2024

Howdy @desteves, goal is to get this reviewed by EoW.
(keep me accountable if that's not the case :) )

@crwaters16
Copy link
Contributor

Hey @desteves! Kody's unexpectedly out today, so I'm taking a look now

@crwaters16 crwaters16 self-requested a review September 20, 2024 19:31
Copy link
Contributor

@crwaters16 crwaters16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small nits - need to check one more thing before hitting the ✅

src/content/docs/pulumi/tutorial/manage-secrets.mdx Outdated Show resolved Hide resolved
src/content/docs/pulumi/tutorial/manage-secrets.mdx Outdated Show resolved Hide resolved
desteves and others added 2 commits September 20, 2024 16:21
Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>
Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>
@desteves
Copy link
Contributor Author

Thank you for taking a look @crwaters16. I went ahead and accepted your suggestions.

@KimJ15 KimJ15 assigned crwaters16 and unassigned kodster28 Sep 24, 2024
@desteves
Copy link
Contributor Author

@crwaters16 just checking if there's anything else needed from my end

@crwaters16 crwaters16 self-requested a review September 24, 2024 21:43
@crwaters16 crwaters16 merged commit 0ff3751 into cloudflare:production Sep 24, 2024
8 checks passed
@crwaters16
Copy link
Contributor

LGTM! Thanks for the contribution 🥳

@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Sep 24, 2024
Copy link

holopin-bot bot commented Sep 24, 2024

Congratulations @desteves, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm1gyrs2g02470cl1znc3ld76

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@desteves desteves deleted the pulumi-tutorial-update branch September 25, 2024 17:57
elithrar pushed a commit that referenced this pull request Oct 15, 2024
* wip

* heading formatting

* wip

* wip

* wip

* updated worker script code

* updated route code

* updated code

* update tutorial flow

* lint check

* grammar

* grammar

* undo settings file change

* cf signup link

* update code to use esc projects

* Update src/content/docs/pulumi/tutorial/manage-secrets.mdx

Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>

* Update src/content/docs/pulumi/tutorial/manage-secrets.mdx

Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>

---------

Co-authored-by: diana esteves <diana@pulumi.com>
Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
* wip

* heading formatting

* wip

* wip

* wip

* updated worker script code

* updated route code

* updated code

* update tutorial flow

* lint check

* grammar

* grammar

* undo settings file change

* cf signup link

* update code to use esc projects

* Update src/content/docs/pulumi/tutorial/manage-secrets.mdx

Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>

* Update src/content/docs/pulumi/tutorial/manage-secrets.mdx

Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>

---------

Co-authored-by: diana esteves <diana@pulumi.com>
Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small product:pulumi size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants