Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Site] format astro files #16839

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Sep 14, 2024

Summary

Formats .astro files with repo rules, to slowly get this all consistent.

</ul>

<p>
This page is meant to be a companion to our <a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the split tags personally, but we can change that in a follow-up PR once we get everything standardized in the first place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I agree. Splitting them makes sense once you're passing 3+ attributes, but just for content feels arbitrary. Can all be tweaked in future as you said - this is mostly just default prettier rules + tabs: https://github.com/cloudflare/cloudflare-docs/blob/production/.prettierrc.mjs

Copy link

gitguardian bot commented Sep 19, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret 8f94767 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 8f94767 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 8f94767 astro.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@KimJ15
Copy link
Collaborator

KimJ15 commented Sep 27, 2024

@KianNH

@KianNH KianNH merged commit 433ad3b into cloudflare:production Oct 1, 2024
6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Oct 1, 2024
Copy link

holopin-bot bot commented Oct 1, 2024

Congratulations @Cherry, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm1qezdfg313670cjtjue4z30p

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

elithrar pushed a commit that referenced this pull request Oct 15, 2024
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.