-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs Site] format astro files #16839
Conversation
</ul> | ||
|
||
<p> | ||
This page is meant to be a companion to our <a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the split tags personally, but we can change that in a follow-up PR once we get everything standardized in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw I agree. Splitting them makes sense once you're passing 3+ attributes, but just for content feels arbitrary. Can all be tweaked in future as you said - this is mostly just default prettier rules + tabs: https://github.com/cloudflare/cloudflare-docs/blob/production/.prettierrc.mjs
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11021221 | Triggered | Generic High Entropy Secret | 8f94767 | astro.config.mjs | View secret |
11021221 | Triggered | Generic High Entropy Secret | 8f94767 | astro.config.mjs | View secret |
11021221 | Triggered | Generic High Entropy Secret | 8f94767 | astro.config.mjs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Congratulations @Cherry, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm1qezdfg313670cjtjue4z30p This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Summary
Formats .astro files with repo rules, to slowly get this all consistent.