-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hyperdrive] Fixing create
Wrangler command
#16919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oxyjun
requested review from
penalosa,
petebacondarwin,
dario-piotrowicz,
irvinebroque,
GregBrimble and
a team
as code owners
September 18, 2024 14:35
github-actions
bot
assigned dario-piotrowicz, GregBrimble, irvinebroque, penalosa and petebacondarwin
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 outstanding issue(s) found.
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Deploying cloudflare-docs with Cloudflare Pages
|
Files with changes (up to 15)
|
thomasgauvin
approved these changes
Sep 18, 2024
patriciasantaana
approved these changes
Sep 18, 2024
marciocloudflare
approved these changes
Sep 18, 2024
vy-ton
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Fixing incorrect Hyperdrive command in Wrangler command list. * Making Hyperdrive and KV commands a partical render. * Update src/content/partials/workers/wrangler-commands/hyperdrive.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> --------- Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Fixing incorrect Hyperdrive command in Wrangler command list. * Making Hyperdrive and KV commands a partical render. * Update src/content/partials/workers/wrangler-commands/hyperdrive.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> --------- Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
maheshwarip
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Fixing incorrect Hyperdrive command in Wrangler command list. * Making Hyperdrive and KV commands a partical render. * Update src/content/partials/workers/wrangler-commands/hyperdrive.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> --------- Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The page with Wrangler commands for
hyperdrive create
incorrectly stated the command neededID
, when in fact it should've beenCONFIG_NAME
.This PR:
hyperdrive create
command doc.AnchorHeading
components for H3 headers to pave the way for future improvements.Screenshots (optional)
Documentation checklist