Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hyperdrive] Fixing create Wrangler command #16919

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

Oxyjun
Copy link
Contributor

@Oxyjun Oxyjun commented Sep 18, 2024

Summary

The page with Wrangler commands for hyperdrive create incorrectly stated the command needed ID, when in fact it should've been CONFIG_NAME.

This PR:

  1. Corrects the hyperdrive create command doc.
  2. Moves all Hyperdrive commands into a separate partial file (i.e. write once, read many arrangement).
  3. Introduces AnchorHeading components for H3 headers to pave the way for future improvements.
    • This has been done to both Hyperdrive and KV command partials.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 outstanding issue(s) found.

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f531261
Status: ✅  Deploy successful!
Preview URL: https://f02bb300.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://jun-hyperdrive-create-comman.cloudflare-docs-7ou.pages.dev

View logs

Copy link

@Oxyjun Oxyjun merged commit 2ea1e38 into production Sep 18, 2024
12 of 13 checks passed
@Oxyjun Oxyjun deleted the jun/hyperdrive/create-command-fix branch September 18, 2024 16:20
vy-ton pushed a commit that referenced this pull request Sep 19, 2024
* Fixing incorrect Hyperdrive command in Wrangler command list.

* Making Hyperdrive and KV commands a partical render.

* Update src/content/partials/workers/wrangler-commands/hyperdrive.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
elithrar pushed a commit that referenced this pull request Oct 15, 2024
* Fixing incorrect Hyperdrive command in Wrangler command list.

* Making Hyperdrive and KV commands a partical render.

* Update src/content/partials/workers/wrangler-commands/hyperdrive.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
* Fixing incorrect Hyperdrive command in Wrangler command list.

* Making Hyperdrive and KV commands a partical render.

* Update src/content/partials/workers/wrangler-commands/hyperdrive.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants